Re: [Uclinux-dist-devel] [PATCH] mm/nommu.c: Fix improperly call of security API in mmap

[Mike Frysinger]

On Fri, Oct 16, 2009 at 11:14, David Howells wrote:
> Eric Paris <eparis@xxxxxxxxxxxxxx> wrote:
>> I really don't like seeing such irrelevant (that's not the right word,
>> but I can't think what is) ifdefs creeping down into the security
>> layer as LSM authors are likely to mess them up in the future. ÂI'd
>> probably rather see the addr_only argument changed into a flags field.
>> ÂOne for addr_only and one flag for not_addr. ÂThe nommu case could
>> just set the not_addr flag and it's obvious how the LSMs (or
>> capabilities if !CONFIG_SECURITY) should handle it, also works if some
>> other future need arises...
>
> A better way still, might be to deny the possibility of CONFIG_SECURITY if
> CONFIG_MMU=n. ÂAfter all, security is sort of pointless when a userspace
> program can just edit the kernel at a whim.

except for MPU users, and arent some security restrictions useful when
talking about networked daemons ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/