Re: [patch] slub: allow stats to be cleared
From: David Rientjes
Date: Sat Oct 17 2009 - 04:54:58 EST
On Sat, 17 Oct 2009, Pekka Enberg wrote:
> > On a semi-related topic, it would have been nice to isolate all statistic
> > files to its own directory: /sys/kernel/slab/kmalloc-256/stats/..., for
> > example. It would have made collecting (and now clearing) all statistics
> > much easier since userspace wouldn't need a predefined list of stat file
> > names to scan. I wonder if Pekka would allow them to be moved...
>
> It's a non-production configuration option and the only known user of the ABI
> is in slabinfo.c so maybe we can just go ahead and do that. Alternatively, I
> think we can preserve the current ABI with symbolic links in sysfs?
>
I think it would be best to just move them to
/sys/kernel/slab/cache/stats. I'll propose a patch and we can see how it
looks.
I remember trying to change `cpuslab_flush' to `cpu_slab_flush' before and
you nack'd it, so I wasn't sure you'd accept this ABI change :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/