Re: [PATCH 2/2] rt2x00: Implement support for rt2800pci

From: Johannes Berg
Date: Sat Oct 17 2009 - 11:08:54 EST


On Sat, 2009-10-17 at 16:54 +0200, Bartlomiej Zolnierkiewicz wrote:

> I also used the opportunity to take a closer look at this driver and
> it seems that it needlessly adds around 2 KLOC to kernel by duplicating
> the common content of rt2800usb.h to rt2800pci.h instead of moving it
> to the shared header (like it is done in the staging crap drivers):

Tell me you're kidding -- comparing 2k duplicated LOC with a driver that
ships its own wifi stack?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part