[re-send PATCH] nfs: Fix nfs_parse_mount_options() double kfree()

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxx> wrote:

> * Trond Myklebust <trond.myklebust@xxxxxxxxxx> wrote:
> 
> > > yes. something miss merged again...
> > > 
> > > need change some lines.
> > 
> > This doesn't match mainline either. To do so, the above kfree() has to 
> > be at the end of the "Opt_xprt_rdma:" case...
> 
> it's from a test patch in tip:out-of-tree:
> 
>   d40bc6b: <not-for-merge> nfs: fix nfs_parse_mount_options() double kfree()
> 
> (attached below)
> 
> that fix is wrong apparently - is there a correct fix upstream perhaps?

Looks like this might be related to a long-standing NFS bug not fixed 
upstream yet. You were Cc:-ed to the original thread and to the original 
patch, see this thread on lkml:

	nfs mount fail on linus 20090402 git

This newer "nfs mount fail" thread got started because the surrounding 
code changed and the pending fix got mismerged. The merged up (and 
fixed) version is attached below - what remains of it by today is a 
memory leak fix.

The original NFS bug was apparently fixed upstream without crediting 
Yinghai and Pekka for finding it, and without a reply to the "nfs mount 
fail on linus 20090402 git" thread, so the patch stayed pending.

	Ingo

-------------->