Re: [PATCH 7/14] drivers/mmc: Move dereference after NULL test

[Uwe Kleine-König]

On Sat, Oct 17, 2009 at 08:40:02AM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@xxxxxxx>
> 
> If the NULL test on mrq is needed, then the derefernce should be after the
> NULL test.
s/derefernce/dereference/
 
> A simplified version of the semantic match that detects this problem is as
> follows (http://coccinelle.lip6.fr/):
> 
> // <smpl>
> @match exists@
> expression x, E;
> identifier fld;
> @@
> 
> * x->fld
>   ... when != \(x = E\|&x\)
> * x == NULL
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@xxxxxxx>
Other than that

Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/