Re: nfs mount fail

[Trond Myklebust]

On Mon, 2009-10-19 at 10:23 +0200, Ingo Molnar wrote:
> * Ingo Molnar <mingo@xxxxxxx> wrote:
> 
> > 
> > * Trond Myklebust <trond.myklebust@xxxxxxxxxx> wrote:
> > 
> > > > --- a/fs/nfs/super.c
> > > > +++ b/fs/nfs/super.c
> > > > @@ -1253,6 +1253,7 @@ static int nfs_parse_mount_options(char *raw,
> > > >  			default:
> > > >  				dfprintk(MOUNT, "NFS:   unrecognized "
> > > >  						"transport protocol\n");
> > > > +				kfree(string);
> > > >  				return 0;
> > > >  			}
> > > >  			break;
> > > 
> > > There is a possible clean up there too. We can move the other kfree() 
> > > calls out of the inner switch statement, and coalesce them all into a 
> > > single call.
> > 
> > Correct - separately from the leak fix. (which potentially wants to go 
> > to -stable as well)
> 
> Not necessarily -stable material though - this is a really light memory 
> leak and only on a rare failure path, i doubt anyone noticed in 
> practice.
> 
> So d508afb fixed all that needed fixing and there's nothing serious 
> pending here. I've reverted all pending bits in tip:out-of-tree, so it's 
> pure -git now. I rarely have to carry any NFS fixes in out-of-tree, this 
> was an odd-one-out exception that fell through the cracks.
> 
> 	Ingo

OK. Could you resend the remaining leak fix, with the fixed up changelog
and attributions so I can pass it on to Linus?

Trond

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/