Re: [PATCH 1/4] MFD: twl4030: add twl4030_codec MFD as a new childto the core

[Mark Brown]

On Mon, Oct 19, 2009 at 03:42:17PM +0300, Peter Ujfalusi wrote:
> New MFD child to twl4030 MFD device.
> This MFD device will be used by the drivers, which needs resources
> from the twl4030 codec like audio and vibra.

> The platform specific configuration data is passed along to the
> child drivers (audio, vibra).

> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx>

> +config TWL4030_CODEC
> +	bool "Support codec part of the TWL4030 family chips"

This seems like something that users shouldn't really have to worry
about selecting explicitly - might it be better to have it selected by
the drivers that use it instead?  It feels like it's an implementation
detail of the driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/