Re: [PATCH 2/2] rt2x00: Implement support for rt2800pci

[Ivo van Doorn]

On Tuesday 20 October 2009, Holger Schurig wrote:
> > I don't agree on this, for starters the whole "abstraction
> > layer as done in the staging driver, really obfuscated the code
> > in multiple areas 
> 
> Ivo, you could look at Orinoco or Libertas. Both WLAN drivers 
> support a multitude of different hardware (Libertas: CF/PCMCIA, 
> SDIO, SD, USB and Orinoco: CF/PCMCIA, PCI, PPC_PMAC). And both 
> have hardware abstraction layers that don't suck, obfuscate or 
> create lots of duplicate code.

Thanks,

> So AFAIK it's not the question *IF* to do hardware abstraction 
> but only a question *HOW* to do it in an intelligent way. Don't 
> luck at one bad implementation and disregard the whole 
> concept :-)

Oh I completely agree, I am not against the extra abstraction layer,
but I do want a nice looking solution. :) I'll take a look at the Orinoco approach.

Thanks,

Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/