Re: [RFC Patch] use MTRR for write combining if PAT is not available

From: Thomas Schlichter
Date: Tue Oct 20 2009 - 15:55:59 EST


Jan Beulich wrote:
> Functionality-wise this looks fine to me; whether the core sysfs changes
> are acceptable I can't judge, though.

OK, I think I should have addressed your comments. Unfortunately I had to use
a little "hack" to make pci_mmap_page_range() work for sysfs and proc. I
placed a "private" pointer in the beginning of both per-file private
structures. So this pointer can be accessed independent from the caller. I
hope this is acceptable.

I dropped the ioremap() and set_memory_wc() patches, I could not implement
reference counting for them and it may interact too much with existing GPU
drivers.

Again, this series should not change the current behavior if either MTRR is
disabled or PAT is enabled. But it helps in the case that MTRR is enabled and
PAT is not available.

What should be done now to get this series on the right "track"?

Kind regards,
Thomas