Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic

[David Daney]

Linus Walleij wrote:
> 2009/10/20 David Daney <ddaney@xxxxxxxxxxxxxxxxxx>:
>
> > > Please do not make that functions inline. They are too large and there
> > > is no benefit of inlining them.
> > If that is the case, then perhaps they should not be defined in a header
> > file.
>
> Of course not. There are apropriate places to put them, but as stated
> I think the use as it is today warrants having them inlined.

I wasn't trying to imply that they shouldn't be inlined, only that if 
you  choose (as you did) to define them in a header file, that they 
*should* be inline.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/