Re: [Linux-fbdev-devel] [PATCH] fbdev: Wrong test on unsigned in fb_set_user_cmap()?

[krzysztof . h1]

"Roel Kluin" <roel.kluin@xxxxxxxxx> pisze:
> struct fb_cmap_user member start is unsigned.

> 

> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>

> ---

> Is this required?

> 


Drop the whole if() as exactly the same condition is checked in the fb_set_cmap() again. Anyway, the check of the cmap->start < 0 does not make any sense as the start is u32 value (most userspace addresses will be lower then 2GB on 32 bit system so the error cannot be caught by the check). I vote for removing the (cmap->start < 0) in the fb_set_cmap as well as most drivers check the start value already in driver's fb_setcolreg() function.

Best regards,
Krzysztof


> diff --git a/drivers/video/fbcmap.c b/drivers/video/fbcmap.c

> index f53b9f1..f46f05f 100644

> --- a/drivers/video/fbcmap.c

> +++ b/drivers/video/fbcmap.c

> @@ -266,7 +266,7 @@ int fb_set_user_cmap(struct fb_cmap_user *cmap, struct
> fb_info *info)

>  		rc = -ENODEV;

>  		goto out;

>  	}

> -	if (cmap->start < 0 || (!info->fbops->fb_setcolreg &&

> +	if ((int)cmap->start < 0 || (!info->fbops->fb_setcolreg &&

>  				!info->fbops->fb_setcmap)) {

>  		rc = -EINVAL;

>  		goto out1;

> 

> ------------------------------------------------------------------------------

> Come build with us! The BlackBerry(R) Developer Conference in SF, CA

> is the only developer event you need to attend this year. Jumpstart your

> developing skills, take BlackBerry mobile applications to market and stay
> 

> ahead of the curve. Join us from November 9 - 12, 2009. Register now!

> http://p.sf.net/sfu/devconference

> _______________________________________________

> Linux-fbdev-devel mailing list

> Linux-fbdev-devel@xxxxxxxxxxxxxxxxxxxxx

> https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

> 
> 






----------------------------------------------------------------------
Zobacz najwiekszy samolot na swiecie!  
Kliknij >>> http://link.interia.pl/f238f

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/