Re: [PATCH] sony_pi: Remove the BKL from sonypi_misc_open

[Frederic Weisbecker]

On Wed, Oct 21, 2009 at 11:41:07PM +0200, John Kacur wrote:
> > What about a pusdown of default_lseek attribution for these
> > fops that don't have any llseek() (and rename it to
> > deprecated_default_lseek() )
> > 
> > Because we can probably fix these fops one by one but what
> > about the next drivers that will have no llseek() ?
> > 
> > We can't attribute default_llseek() by default anymore for
> > further fops that are to come.
> > 
> > 
> 
> Frederic, I think it is still useful to explicity set to no_llseek, 
> drivers that don't use llseek.


Yeah, I agreed.


 
> I also have to agree with you, that we should no longer be using a 
> default_llseek that relies on the BKL.
> 
> That is a rather large effort though. All drivers that don't specify an 
> llseek function, need to either set it to no_llseek, or as you are 
> proposing a deprecated default_llseek that uses the bkl.
> 
> thinking of how to start this.
> 
> John


This is a rather large effort indeed but this pushdown seems
the only way to remove default_llseek as the default llseek()
callback.

The more we wait, the more code we'll need to review and fix.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/