Re: [RFC][PATCH] Add prctl to set sibling thread names

[Arjan van de Ven]

On Wed, 21 Oct 2009 16:21:37 -0700
john stultz <johnstul@xxxxxxxxxx> wrote:

> 
> Taking a very raw attempt at this, I scratched out the following
> simple implementation. I'd appreciate any review or suggestions for
> improvements. I'm not at all certain the passing of the thread pid_t
> through the unsigned long is valid, for instance, or if
> same_thread_group() is the right check to make sure we only change
> siblings and not tid from other processes. So any advice on better
> approaches would be great.
> 
> +				return -EINVAL;
> +
> +			set_task_comm(tsk, comm);


you're pretty much the first now who touches ->comm from
not-the-thread-itself.... are you sure that is safe?


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/