Re: [RFC Patch] use MTRR for write combining if PAT is not available
From: Thomas Schlichter
Date: Fri Oct 23 2009 - 03:25:02 EST
Suresh Siddha wrote:
> On Thu, 2009-10-22 at 21:31 -0700, Jesse Barnes wrote:
> > Here's a quick & dirty version, totally untested. A cleaner approach
> > would be to separate the WC mapping routines and hide the return
> > -EINVAL in arch specific code...
>
> Jesse How about this patch? Doing this in x86 is cleaner.
>
> I would like Acks/sign-offs-by Thomas, Eric and Jesse, if it is ok with
> this patch and works.
Hmm, at this point I already was more than a week ago:
http://marc.info/?l=linux-kernel&m=125537770514713&w=2
OK, I also modified ioremap() and set_memory_wc() but your patch is just part
of what I did there...
And Eric Anholt answered:
> Seems like we should install an MTRR instead. Requiring userland to set
> up the MTRR on the kernel's behalf is backwards.
Where I totally agree with him.
Regards,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/