Re: [PATCH] powerpc: Fix build failure when CONFIG_USB=y

From: Alistair Popple
Date: Tue Sep 16 2014 - 00:12:52 EST


Thanks for fixing these!

Acked-by: Alistair Popple <alistair@xxxxxxxxxxxx>

On Thu, 21 Aug 2014 09:16:04 Pranith Kumar wrote:
> We are enabling USB unconditionally which results in following build failure
>
> drivers/built-in.o: In function `tb_drom_read':
> (.text+0x1b62b70): undefined reference to `usb_speed_string'
> make: *** [vmlinux] Error
>
> Enable USB only if USB_SUPPORT is set to avoid such failures
>
> Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
> ---
> arch/powerpc/platforms/44x/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/44x/Kconfig
> b/arch/powerpc/platforms/44x/Kconfig index 3e7deb2..82f2da2 100644
> --- a/arch/powerpc/platforms/44x/Kconfig
> +++ b/arch/powerpc/platforms/44x/Kconfig
> @@ -215,7 +215,7 @@ config AKEBONO
> select NET_VENDOR_IBM
> select IBM_EMAC_EMAC4
> select IBM_EMAC_RGMII_WOL
> - select USB
> + select USB if USB_SUPPORT
> select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
> select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD
> select MMC_SDHCI

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/