Re: [Patch Part3 V5 5/8] iommu/vt-d: Enhance intel_irq_remapping driver to support DMAR unit hotplug

[Jiang Liu]

On 2014/9/15 10:20, Yijing Wang wrote:
>> +static void ir_remove_ioapic_hpet_scope(struct intel_iommu *iommu)
>> +{
>> +	int i;
>>  
>> -			ir_parse_one_hpet_scope(scope, iommu);
>> -		}
>> -		start += scope->length;
>> -	}
>> +	for (i = 0; i < MAX_HPET_TBS; i++)
>> +		if (ir_hpet[i].iommu == iommu)
>> +			ir_hpet[i].iommu = NULL;
> 
> Hi Gerry, why not reset whole ir_hpe and ir_ioapic data struct?
Hi Yijing,
	Thanks for review. Zero is legal for id, bus and devfn in
struct ioapic_scope and struct hpet_scope. So we use domain field
as a flag to mark entry valid or invalid and only reset iommu field.

Regards!
Gerry
> 
> 
> 
>>  
>> -	return 0;
>> +	for (i = 0; i < MAX_IO_APICS; i++)
>> +		if (ir_ioapic[i].iommu == iommu)
>> +			ir_ioapic[i].iommu = NULL;
>>  }
>>  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/