Re: [PATCH RESEND] thermal: Add QPNP PMIC temperature alarm driver

[Ivan T. Ivanov]

On Mon, 2014-09-15 at 19:02 +0300, Georgi Djakov wrote:

<snip>

> > +Example:
> > +
> > +	thermal-alarm@2400 {
> > +		compatible = "qcom,qpnp-temp-alarm";
> > +		reg = <0x2400>;
> > +		interrupts = <0 0x24 0 IRQ_TYPE_EDGE_RISING>;
> > +		label = "pm8941_tz";
> > +		io-channels = <&pm8941_vadc VADC_DIE_TEMP>;
> > +		io-channel-names = "thermal";
> > +	};
> 
> Maybe describe the trip points in the DT?

I am not sure. Trip points are not arbitrary selectable. Hardware
have 4 predefined operating modes, if I could say.

0 = {105 C, 125 C, 145 C}
1 = {110 C, 130 C, 150 C}
2 = {115 C, 135 C, 155 C}
3 = {120 C, 140 C, 160 C}

Everything which driver could select is one of 0...3.

Rest of the comments will be fixed in next version.

Thanks,
Ivan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/