RE: [PATCH 00/11] staging: comedi: move comedi_fc functionality into core

[Hartley Sweeten]

On Tuesday, September 16, 2014 12:44 AM, Ian Abbott wrote:
> On 15/09/14 19:21, Hartley Sweeten wrote:
>> Other than I think the comedi_fc.c functions should be migrated to
>> comedi_buf.c instead of drivers.c I have not problems with this.
>
> I think it's debatable. The only one of the three functions you 
> mentioned that touches the buffer is comedi_inc_scan_progress(), and I'd 
> rather keep that with comedi_bytes_per_scan().

Fair enough. I might end up moving some of them later based on some patches
I'm working on, but for now having them in drivers.c is fine.

>> And, patch 11 does have a conflict with your "... use dma_alloc_coherent..."
>> patches.
>
> Yes, I'll have to fix up one or the other, depending which gets applied 
> first (unless git can magically sort it out with a three way merge).

If not it's an easy rebase.

Regards,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/