Re: [PATCH 2/7] Define new syscalls readv2,preadv2,writev2,pwritev2

[Milosz Tanski]

Good point. I will put the shared functionality in a static function.

On Tue, Sep 16, 2014 at 3:20 PM, Jeff Moyer <jmoyer@xxxxxxxxxx> wrote:
> Milosz Tanski <milosz@xxxxxxxxx> writes:
>
>> New syscalls with an extra flag argument. For now all flags except for 0 are
>> not supported.
>
> The blatant copy-n-paste of the vectored functions bothers me.  I'll
> withold judgement until I've seen your next version of the patch series,
> though.
>
> Cheers,
> Jeff



-- 
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016

p: 646-253-9055
e: milosz@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/