Re: [PATCH v2 1/3] ARM: dts: imx6: add pm_power_off support for i.mx6 chips

[Robin Gong]

On Wed, Sep 17, 2014 at 09:24:37AM +0200, Sascha Hauer wrote:
> On Wed, Sep 17, 2014 at 03:17:38PM +0800, Robin Gong wrote:
> > On Wed, Sep 17, 2014 at 08:06:49AM +0200, Sascha Hauer wrote:
> > > On Wed, Sep 17, 2014 at 11:45:15AM +0800, Robin Gong wrote:
> > > > On Wed, Sep 17, 2014 at 10:10:45AM +0800, Shawn Guo wrote:
> > > > > On Fri, Sep 12, 2014 at 04:48:57PM +0800, Robin Gong wrote:
> > > > > > All chips of i.mx6 can be powered off by programming SNVS.
> > > > > > For example :
> > > > > > On i.mx6q-sabresd board, PMIC_ON_REQ connect with external
> > > > > > pmic ON/OFF pin, that will cause the whole PMIC powered off
> > > > > > except VSNVS. And system can restart once PMIC_ON_REQ goes
> > > > > > high by push POWRER key.
> > > > > 
> > > > > What's the behavior for those boards on which PMIC_ON_REQ isn't
> > > > > connected to anywhere?
> > > > >
> > > > System can't be powered off if not connect PMIC_ON_REQ. Although all of our
> > > > reference design for i.mx6 chips are connecting  PMIC_ON_REQ with external
> > > > PMIC, we need consider others may not use external PMIC. I'll add the info
> > > > into commit log or Kconfig.
> > > 
> > > You should add the information to the dtsi file in form of a
> > > status = "disabled" property so that boards that actually have the
> > > feature can enable it.
> > > 
> > > Sascha
> > Hi Sacha, but that's  SOC level feature and it's harmless even if others don't
> > want to use this pin to control external PMIC.
> 
> Harmless? If a pm_power_off hook is registered I expect it to work, but
> it doesn't work when my board does not have the connection between the
> PMIC and the SoC. Even worse, if my board has some custom power of
> method you overwrite my method in the snvs poweroff driver with a method
> that does not work on my board.
> 
> Sascha
Sorry, I suppose PMIC_ON_REQ is the only way to control external power ON/OFF.
If they don't use PMIC_ON_REQ, I assume they drop poweroff feature.
Yes, I agree with you that set status as 'disable' in DTS make things clear if
they want to use other pins to control external power. But I'm not sure whether
we need consider this special case to 'disable' the soc level feature and
re-enable on many boards level DTS? Also, I don't understand why they give up
PMIC_ON_REQ and consume another pin to do the same thing....But I'm ok if both
you and Shawn agree with it.
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/