Re: [PATCH 1/1] staging: rtl8723au: fix sparse incorrect type assignment warnings

From: Dan Carpenter
Date: Wed Sep 17 2014 - 04:26:57 EST


On Tue, Sep 16, 2014 at 11:28:09PM +0100, Kieron Browne wrote:
> Use cpu_to_le16 to cast int for assignment to __le16 members
>

"cast" is the wrong word. It's really doing a byte swap. It fixes a
bug on big endian systems.

But the patch is ok and matches how the other rtl drivers do it.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/