Re: [PATCH] vfs: workaround gcc <4.6 build error in link_path_walk()

[James Hogan]

On 16/09/14 18:39, Al Viro wrote:
> On Tue, Sep 16, 2014 at 01:07:35PM +0100, James Hogan wrote:
>> Commit d6bb3e9075bb (vfs: simplify and shrink stack frame of
>> link_path_walk()) introduced build problems with GCC versions older than
>> 4.6 due to the initialisation of a member of an anonymous union in
>> struct qstr without enclosing braces.
>>
>> This hits GCC bug 10676 [1] (which was fixed in GCC 4.6 by [2]), and
>> causes the following build error:
>>   fs/namei.c: In function 'link_path_walk':
>>   fs/namei.c:1778: error: unknown field 'hash_len' specified in initializer
>>
>> This is worked around by adding explicit braces.
> 
> IOW, the same thing QSTR_INIT is doing...

QSTR_INIT only initialises len and name, not the hash.

Cheers
James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/