Re: [PATCH 1/2] regulator: st-pwm: get voltage and duty table from dts

[Doug Anderson]

Hi,

On Wed, Sep 17, 2014 at 9:51 AM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Wed, Sep 17, 2014 at 09:07:59PM +0800, Chris Zhong wrote:
>> Get voltage & duty table from device tree might be better, other platforms can also use this
>> driver without any modify.
>>
>> Signed-off-by: Chris Zhong <zyw@xxxxxxxxxxxxxx>
>> ---
>>
>>  drivers/regulator/Kconfig  |    1 -
>>  drivers/regulator/st-pwm.c |   80 +++++++++++++++++++++++---------------------
>
> You need to update the binding document if you're updating the DT
> bindings.

Mark: See part 2 <https://patchwork.kernel.org/patch/4924381/>.
Unfortunately you weren't CCed on that.  It also should have been
patch #1, not patch #2.

Chris: please change the order and make sure Mark is CCed on the
bindings.  Probably anyone CCed on the code change should be on the
bindings change (and probably vice versa, but maybe not as critical).

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/