Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control

From: Sebastian Reichel
Date: Wed Sep 17 2014 - 12:55:42 EST


On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote:
> On Wed, 17 Sep 2014, Nishanth Menon wrote:
> > ti,system-power-controller is more or less the standard way of
> > indicating that the PMIC is the system wide power controller and hence
> > may be used to switch off the system. Almost ALL TI PMIC drivers and
> > many Maxim PMIC drivers follow the same style.
> >
> > So support 'ti,system-power-controller' in addition to the usual
> > 'ti,use_poweroff' to indicate that the PMIC instance has control for
> > switching off the system.
> >
> > Signed-off-by: Nishanth Menon <nm@xxxxxx>
> > ---
> >
> > V2: picked up documentation suggestion from Sebastien
>
> It would be good to get Sebastian's Ack.

Acked-By: Sebastian Reichel <sre@xxxxxxxxxx>

[...]

> > +- ti,system-power-controller: This indicates that TWL4030 is the
> > + power supply master of the system. With this flag, the chip will
> > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
> > + system poweroffs.

One minor thing: While the documentation is updated you may want to
fix the typo "will initiates" to "will initiate" (or just drop the
"will").

-- Sebastian

Attachment: signature.asc
Description: Digital signature