Re: [PATCH 17/18] usbip: Increment version number to 1.2.1

[Denys Vlasenko]

On Wednesday 17 September 2014 01:38, Maximilian Eschenbacher wrote:
> From: Dominik Paulus <dominik.paulus@xxxxxx>
> 
> Also increment the kernel module version number to match the
> userspace version, as compatibility with old userspace utilities
> is now at least partially broken.
> 
> Signed-off-by: Maximilian Eschenbacher <maximilian@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Fjodor Schelichow <fjodor.schelichow@xxxxxxxxxxx>
> Signed-off-by: Johannes Stadlinger <johannes.stadlinger@xxxxxx>
> Signed-off-by: Dominik Paulus <dominik.paulus@xxxxxx>
> Signed-off-by: Tobias Polzer <tobias.polzer@xxxxxx>
> ---
>  drivers/usb/usbip/usbip_common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/usbip/usbip_common.h b/drivers/usb/usbip/usbip_common.h
> index 6831d99..a5f416e 100644
> --- a/drivers/usb/usbip/usbip_common.h
> +++ b/drivers/usb/usbip/usbip_common.h
> @@ -32,7 +32,7 @@
>  #include <uapi/linux/usbip.h>
>  #include <linux/kfifo.h>
>  
> -#define USBIP_VERSION "1.0.0"
> +#define USBIP_VERSION "1.2.1"

You can use UTS_RELEASE instead - it would handle the task of identifying
the version of running code as good, or better, than a subsystem-specific
version id.
For one, as this patch attests, subsystem-specific ids tend to become stale...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/