Re: [PATCH] cgroup: fix unbalanced locking

[Tejun Heo]

On Thu, Sep 18, 2014 at 05:28:46PM +0800, Zefan Li wrote:
> cgroup_pidlist_start() holds cgrp->pidlist_mutex and then calls
> pidlist_array_load(), and cgroup_pidlist_stop() releases the mutex.
> 
> It is wrong that we release the mutex in the failure path in
> pidlist_array_load(), because cgroup_pidlist_stop() will be called
> no matter if cgroup_pidlist_start() returns errno or not.
> 
> Fixes: 4bac00d16a8760eae7205e41d2c246477d42a210
> Cc: <stable@xxxxxxxxxxxxxxx> # 3.14+
> Signed-off-by: Zefan Li <lizefan@xxxxxxxxxx>

Applied to cgroup/for-3.17-fixes.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/