Re: [PATCH v3 03/21] powerpc/8xx: exception InstructionAccess does not exist on MPC8xx

[Joakim Tjernlund]

christophe leroy <christophe.leroy@xxxxxx> wrote on 2014/09/18 21:11:01:
> 
> 
> Le 18/09/2014 20:12, Joakim Tjernlund a écrit :
> > leroy christophe <christophe.leroy@xxxxxx> wrote on 2014/09/18 
18:42:14:
> >
> >> Le 18/09/2014 17:15, Joakim Tjernlund a écrit :
> >>> Christophe Leroy <christophe.leroy@xxxxxx> wrote on 2014/09/17
> > 18:36:57:
> >>>> Exception InstructionAccess does not exist on MPC8xx. No need to
> > branch
> >>> there from somewhere else.
> >>>> Handling can be done directly in InstructionTLBError Exception.
> >>>>
> >>>> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
> >>        . = 0x1200
> >>    DataStoreTLBMiss:
> >> @@ -477,7 +475,11 @@ DataStoreTLBMiss:
> >>     */
> >>        . = 0x1300
> >>    InstructionTLBError:
> >> -    b    InstructionAccess
> >> +    EXCEPTION_PROLOG
> >> +    mr    r4,r12
> >> +    mr    r5,r9
> >> +    /* 0x400 is InstructionAccess exception, needed by 
bad_page_fault()
> > */
> >> +    EXC_XFER_LITE(0x400, handle_page_fault)
> > You should have the code in TLBMiss and have the TLBError branch there 
as
> > that is the common case.
> As far as I remember, I tried it already but we don't have enough space 
> in TLBmiss for that. We can only have 40 instructions.

Do your other optimizations first, then you might have space :)

 Jocke
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/