Re: [PATCHv2] serial: 8250: Add Quark X1000 to 8250 PCI driver

[Bryan O'Donoghue]

On 19/09/14 11:58, Heikki Krogerus wrote:
> On Fri, Sep 19, 2014 at 08:43:49AM +0100, Bryan O'Donoghue wrote:
> > Adds PCI identifier for the X1000
> > Adds clocking and register size and register shift
> >
> > Signed-off-by: Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx>
> > ---
> >   drivers/tty/serial/8250/8250_pci.c | 33 +++++++++++++++++++++++++++++++++
> >   1 file changed, 33 insertions(+)
>
> The UART on Quark SoC has an integrated DMA engine and Kean Ho (CC'd)
> is working with support for it. The plan is to add completely separate
> probe driver for the Quark UART. Dealing with the integrated DMA
> engine is too much for a quirk in 8250_pci.c.
>
> So we can take this now and when Kean Ho is ready he needs to
> basically revert it, or you could already introduce the new probe
> driver, 8250_quark.c, and Kean Ho can then add the DMA engine handling
> later to it.
>
> IMO we should add the 8250_quark.c already now.

Sounds great - is the 8250_quark.c code ready ?

If so then fantastic I agree with you.

If not then, lets do as you suggest Heikki and apply the simple patch 
above in the interim.


Best,
BOD


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/