Re: [PATCH] blk-timeout: fix blk_add_timer

[Jens Axboe]

On 09/19/2014 07:53 AM, Ming Lei wrote:
> Commit 8cb34819cdd5d(blk-mq: unshared timeout handler) introduces
> blk-mq's own timeout handler, and removes following line
> 
> 	blk_queue_rq_timed_out(q, blk_mq_rq_timed_out);
> 
> then cause blk_add_timer() to do nop in case of blk-mq.
> 
> This patch fixes the problem by bypassing the check for blk-mq.

Good catch, this explains something I ran into yesterday on a missing
timer. I had a hard time understanding your description here, I'll
reword it a little bit and apply. Thanks!

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/