Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

[Peter Zijlstra]

On Thu, Sep 18, 2014 at 12:33:34PM -0700, Dave Hansen wrote:
> 
> 
> This is my third attempt to fix this.  It's definitely simpler
> than the previous set.  This takes Peter Z's suggestion to just
> create and use a different topology when we see these
> "Cluster-on-Die" systems.


> +static struct sched_domain_topology_level numa_inside_package_topology[] = {
> +#ifdef CONFIG_SCHED_SMT
> +	{ cpu_smt_mask, cpu_smt_flags, SD_INIT_NAME(SMT) },
> +#endif
> +	{ NULL, },
> +};

Yes, that looks ok. The only thing is that we need to fix the MC and DIE
masks. But I can do that in a separate patch. This should ideally still
contain the MC domain (as in LLC) mask, just not the DIE domain (as in
pkg).

But as you already saw, bits are somewhat icky atm.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/