Re: [PATCH 5/7] signal: Silence nested-externs warnings

[Jeff Kirsher]

On Fri, 2014-09-19 at 17:35 +0200, Richard Weinberger wrote:
> Am 19.09.2014 17:29, schrieb Jeff Kirsher:
> > From: Mark Rustad <mark.d.rustad@xxxxxxxxx>
> > 
> > Silence nested-externs warnings for these, as these nested
> > externs are truly wanted.
> > 
> > CC: Oleg Nesterov <oleg@xxxxxxxxxx>
> > CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > CC: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > CC: Richard Weinberger <richard@xxxxxx>
> > CC: Brian Norris <computersforpeace@xxxxxxxxx>
> > Signed-off-by: Mark Rustad <mark.d.rustad@xxxxxxxxx>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
> > ---
> >  include/linux/signal.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/include/linux/signal.h b/include/linux/signal.h
> > index 750196f..e68ae6b 100644
> > --- a/include/linux/signal.h
> > +++ b/include/linux/signal.h
> > @@ -67,7 +67,9 @@ static inline int sigismember(sigset_t *set, int _sig)
> >  
> >  static inline int sigisemptyset(sigset_t *set)
> >  {
> > +	DIAG_PUSH DIAG_IGNORE(nested-externs)
> 
> Do we really want to clutter the source with such tags?
> Does this even build? i.e. how does gcc know to ignore that?
> 
> rw@azrael:~/linux (ubi-wlcrash $)> git grep DIAG_PUSH | wc -l
> 0
> 
> Thanks,
> //richard

See patch 1 of the series.

Attachment: signature.asc
Description: This is a digitally signed message part