Re: [PATCH 2/2] powerpc32: add support for csum_add()

[Joakim Tjernlund]

Christophe Leroy <christophe.leroy@xxxxxx> wrote on 2014/09/19 15:57:56:

> +#define HAVE_ARCH_CSUM_ADD
> +static inline __wsum csum_add(__wsum csum, __wsum addend)
> +{
> +    __asm__("\n\
> +   addc %0,%0,%1 \n\
> +   addze %0,%0 \n\
> +   "
> +   : "=r" (csum)
> +   : "r" (addend), "0"(csum));

hmm, I wonder if not this is better written as:
: "+r" (csum): "r" (addend))

  Jocke
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/