Re: [RFC PATCH] rcu: Change use of __this_cpu ops on a bool type

From: Pranith Kumar
Date: Fri Sep 19 2014 - 19:35:47 EST


On Fri, Sep 19, 2014 at 4:57 PM, Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote:
> On Fri, Sep 19, 2014 at 01:26:03PM -0400, Pranith Kumar wrote:
>> __this_cpu_{read/write}() uses sizeof() to determine the size of the variable.
>> Using this operation on a bool type causes sparse to complain.
>>
>> I checked the generated code and there is only a slight difference in
>> instructions generated.
>>
>> I am not sure this warning by sparse is really valid, but let us silence it
>> anyways.
>>
>> Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
>
> I believe this warning was actually fixed with current versions of
> Sparse; there was some discussion and a patch on the linux-sparse
> mailing list. Can you please recheck with the latest Sparse from git,
> and if it still breaks, please raise that on linux-sparse?
>

Yup, looks like the latest version of sparse fixes this. Please ignore
this patch. Thanks!

--
Pranith
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/