Re: [PATCH] ARM: dts: Add initial DTS file for Sony Xperia Z1 phone

[Frank Rowand]

On 9/16/2014 4:14 PM, Tim Bird wrote:
> 
> 
> On 09/16/2014 04:08 PM, Kumar Gala wrote:
>>
>> On Sep 16, 2014, at 4:03 PM, Tim Bird <tim.bird@xxxxxxxxxxxxxx> wrote:
>>
>>> This DTS has initial support for just a serial console, for the
>>> Sony Xperia Z1 phone.  This phone uses a QualComm 8074 processor.
>>>
>>
>> Qualcomm, the C isn’t caps.
> 
> Will fix.
>>
>>> Signed-off-by: Tim Bird <tim.bird@xxxxxxxxxxxxxx>
>>> ---
>>> arch/arm/boot/dts/Makefile                   |    1 +
>>> arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts |   18 ++++++++++++++++++
>>> 2 files changed, 19 insertions(+)
>>> create mode 100644 arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index b8c5cd3..680ce7e 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -341,6 +341,7 @@ dtb-$(CONFIG_ARCH_PRIMA2) += prima2-evb.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += \
>>> 	qcom-apq8064-ifc6410.dtb \
>>> 	qcom-apq8074-dragonboard.dtb \
>>> +	qcom-apq8074-xperia-z1.dtb \
>>> 	qcom-apq8084-mtp.dtb \
>>> 	qcom-msm8660-surf.dtb \
>>> 	qcom-msm8960-cdp.dtb
>>> diff --git a/arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts b/arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts
>>> new file mode 100644
>>> index 0000000..59b3fa1
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts
>>> @@ -0,0 +1,18 @@
>>> +#include "qcom-msm8974.dtsi"
>>> +
>>> +/ {
>>> +	model = "Sony Xperia Z1 phone";
>>> +	compatible = "qcom,msm8974”;
>>
>> Should have a board compat as well

Also need to add the board compat string, and "qcom,msm8974” to the list of
strings in arch/arm/mach-qcom/board.c: qcom_dt_match[].


> I'll ask Bjorn what we want to do here.  There was a compat that I stripped,
> but I'm not sure we settled on the official name we want.  In any event,
> will fix.
>>
>>> +	qcom,msm-id = <126 8 0>, <185 8 0>, <186 8 0>;
>>
>> We don’t have qcom,msm-id upstream at this time.
> Do I just leave this out, then?
> 
> Thanks.
>  -- Tim
> 
> P.S. By now you probably noticed I mis-typed device-tree@xxxxxxxxxxxxxxxx  I'll fix that also.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> .
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/