Re: [PATCH 1/1] checkpatch: check for subject uniqueness in git repository.

[Fabian Frederick]

> On 16 September 2014 at 18:31 Joe Perches <joe@xxxxxxxxxxx> wrote:
>
>
> On Tue, 2014-09-16 at 18:15 +0200, Fabian Frederick wrote:
> > > On 16 September 2014 at 05:22 Joe Perches <joe@xxxxxxxxxxx> wrote:
> > > On Mon, 2014-09-15 at 20:43 +0200, Fabian Frederick wrote:
> > > > Adding patch subject uniqueness check in checkpatch --strict mode.
> > > > See Documentation/SubmittingPatches/globally-unique identifier.
> > >
> > > Perhaps something like this?
> []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > > +Â Â Âif ($check && $#git_commits < 1 && which("git") && -e ".git") {
> > > +Â Â Â Â Â Â Âmy $output = `git log --no-color --format='%H %s' 2>&1`;
> > > +Â Â Â Â Â Â Â$output =~ s/^\s*//gm;
> > > +Â Â Â Â Â Â Â@git_commits = split("\n", $output);
> > > +Â Â Â}
>
> > Perfect ! :)
>
> Except for that _really, really_ long time to do the
> git log of all commits...
>
> Maybe the git log should be enabled only with another
> command-line option.
>
Hello Joe,

checkpatck does already execute git log in seed_camelcase_includes and
git_commit_info when .git exists
so we could add some specific option instead like --complete --verbose
--checkduplicates or something for this test ?

Regards,
Fabian
Â
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/