Re: [PATCH v2 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant

[Tejun Heo]

On Mon, Sep 22, 2014 at 12:43:32PM +0800, Zefan Li wrote:
> Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags")
> defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing
> because it is used as bit number. Redefine it as decimal bit number.
> 
> Note this changes the bit position of PFA_NOW_NEW_PRIVS from 1 to 0.
> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
> [ lizf: slightly modified subject and changelog ]
> Signed-off-by: Zefan Li <lizefan@xxxxxxxxxx>

All the patches look good to me.  I can't say I'm a big fan of
function defining macros but I don't have prettier alternatives
either.  Once Peter/Ingo acks the patches, I'll route them through
cgroup/for-3.17-fixes.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/