Re: [PATCH 1/5] extcon: gpio: Minor cleanups

[Chanwoo Choi]

Hi George,

On 09/09/2014 01:14 PM, George Cherian wrote:
> Minor Cleanups
>  - Order the include files in alphabetical order.
>  - Fix description of state_off in extcon_gpio.h
>  - Add a descrition for check_on_resume in extcon_gpio.h
> 
> Signed-off-by: George Cherian <george.cherian@xxxxxx>

I modify the name/description of patch to keep standary coding style
and applied it.

Thanks,
Chanwoo Choi

> ---
>  drivers/extcon/extcon-gpio.c       | 10 +++++-----
>  include/linux/extcon/extcon-gpio.h |  4 +++-
>  2 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> index 5b7ec27..72f19a3 100644
> --- a/drivers/extcon/extcon-gpio.c
> +++ b/drivers/extcon/extcon-gpio.c
> @@ -20,16 +20,16 @@
>   *
>  */
>  
> -#include <linux/module.h>
> -#include <linux/kernel.h>
> +#include <linux/extcon.h>
> +#include <linux/extcon/extcon-gpio.h>
> +#include <linux/gpio.h>
>  #include <linux/init.h>
>  #include <linux/interrupt.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  #include <linux/workqueue.h>
> -#include <linux/gpio.h>
> -#include <linux/extcon.h>
> -#include <linux/extcon/extcon-gpio.h>
>  
>  struct gpio_extcon_data {
>  	struct extcon_dev *edev;
> diff --git a/include/linux/extcon/extcon-gpio.h b/include/linux/extcon/extcon-gpio.h
> index 8900fdf..0b17ad4 100644
> --- a/include/linux/extcon/extcon-gpio.h
> +++ b/include/linux/extcon/extcon-gpio.h
> @@ -34,8 +34,10 @@
>   * @irq_flags:		IRQ Flags (e.g., IRQF_TRIGGER_LOW).
>   * @state_on:		print_state is overriden with state_on if attached.
>   *			If NULL, default method of extcon class is used.
> - * @state_off:		print_state is overriden with state_on if detached.
> + * @state_off:		print_state is overriden with state_off if detached.
>   *			If NUll, default method of extcon class is used.
> + * @check_on_resume:	Boolean describing whether to check the state of gpio
> + *			while resuming from sleep.
>   *
>   * Note that in order for state_on or state_off to be valid, both state_on
>   * and state_off should be not NULL. If at least one of them is NULL,
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/