Re: [PATCH 1/2] i2c: cadence: Remove .owner field for driver

From: Michal Simek
Date: Mon Sep 22 2014 - 05:37:08 EST


On 09/20/2014 11:11 AM, Wolfram Sang wrote:
> On Wed, Aug 13, 2014 at 01:56:51PM +0200, Michal Simek wrote:
>> There is no need to init .owner field.
>>
>> Based on the patch from Peter Griffin <peter.griffin@xxxxxxxxxx>
>> "mmc: remove .owner field for drivers using module_platform_driver"
^
this shouldn't be there.

>>
>> This patch removes the superflous .owner field for drivers which
>
> It says drivers, but does only one...

I have c&p this from Peter's description that's why there are just drivers.

>
>> use the module_platform_driver API, as this is overriden in
>> platform_driver_register anyway."
>
> ... so: any interest in doing this for the whole subsystem? Basically
> good catch, though.

Mark was also interested about doing this for spi. Doing this for the whole
kernel will be the best. coccinelle script
is good option I have never played with it.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


Attachment: signature.asc
Description: OpenPGP digital signature