Re: [RFC PATCH] x86: Use ACCESS_ONCE() for atomic_read()

[Peter Zijlstra]

On Tue, Sep 23, 2014 at 09:32:05AM -0400, Pranith Kumar wrote:
> On Mon, Sep 22, 2014 at 4:07 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > On Mon, Sep 22, 2014 at 03:53:09PM -0400, Pranith Kumar wrote:
> >> Use the much easier to read ACCESS_ONCE() which is basically the same thing as
> >> the cast to volatile.
> >>
> >> Please note the change in volatile cast: ACCESS_ONCE(v)->counter to
> >> ACCESS_ONCE(v->counter).
> >>
> >> Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
> >> ---
> >>  arch/x86/include/asm/atomic.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > If you want to do something like so, then be consistent and do them all.
> 
> Hi Peter,
> 
> The changelog across all archs is as follows
> 
> 18 files changed, 24 insertions(+), 24 deletions(-)
> 
> Do you think it is better to send it as one patch or break up into
> patch for each arch?

I'd send it as a single patch, its small enough as is, and basically
just a 'style' update.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/