Re: [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs

[David Miller]

From: Michal Marek <mmarek@xxxxxxx>
Date: Tue, 23 Sep 2014 17:44:00 +0200

> Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET
> instead of selecting NET") removed what happened to be the only instance
> of 'select NET'. Defconfigs that were relying on the select now lack
> networking support.
> 
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxx
> Signed-off-by: Michal Marek <mmarek@xxxxxxx>

On the contrary, since NET was being selected for them indirectly
previously, weren't they depending instead upon NET being enabled?

Likewise for SCSI_NETLINK, SCSI_FC_ATTRS, and whatever was triggering
the select upon them?

I'll remember this as yet another why 'select' is to be avoided at
just about all costs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/