Re: [PATCH v3 2/3] sched: add macros to define bitops for task atomic flags

[Kees Cook]

On Tue, Sep 23, 2014 at 3:01 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Tue, Sep 23, 2014 at 03:44:59PM +0800, Zefan Li wrote:
>> This will simplify code when we add new flags.
>>
>> v3:
>> - Kees pointed out that no_new_privs should never be cleared, so we
>> shouldn't define task_clear_no_new_privs(). we define 3 macros instead
>> of a single one.

Thanks! This looks good to me.

>>
>> v2:
>> - updated scripts/tags.sh, suggested by Peter.
>>
>> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
>> Cc: Miao Xie <miaox@xxxxxxxxxxxxxx>
>> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
>> Cc: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Zefan Li <lizefan@xxxxxxxxxx>
>
> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/