Re: [PATCH 0/7] Silence even more W=2 warnings

From: Joe Perches
Date: Tue Sep 23 2014 - 15:04:33 EST


On Tue, 2014-09-23 at 20:44 +0200, Borislav Petkov wrote:
> On Tue, Sep 23, 2014 at 05:24:22PM +0000, Rustad, Mark D wrote:
> > Perhaps checkpatch would be a better gatekeeper for new code. OTOH,
> > some of those nested externs have already been eliminated, so at
> > least for now the warning is serving a purpose since it is scrubbing
> > existing code.
>
> Yep, eliminating would be optimal. If it is in checkpatch, it is much
> easier to manage.

checkpatch is simply a regex tester, so it's only appropriate
if the false-positive false-negative rate is acceptable.

Coccinelle may be better at whatever test is being considered.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/