Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

From: Joe Perches
Date: Tue Sep 23 2014 - 15:18:06 EST


On Tue, 2014-09-23 at 21:02 +0200, Francois Romieu wrote:
> Mark Einon <mark.einon@xxxxxxxxx> :
> [...]
> > > No need for the #define here, just assigne et131x_pm_ops to .driver.pm
> > > directly, its members will be NULL and thus never called. Also, you can
> > > make et131x_pm_ops const.
> >
> > Ok, I can change this.
> >
> > Btw, this appears to be a fairly standard way of using .driver.pm among
> > ethernet drivers, e.g. see 3com/3c59x.c, atheros, marvell... - perhaps
> > there is a case for changing all instances of this code?
>
> How about kernel tinification ?

The tiny case where a large number of ethernet drivers are included?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/