Re: [PATCH v5 1/4] ftracetest: Initial commit for ftracetest

From: Masami Hiramatsu
Date: Tue Sep 23 2014 - 21:16:58 EST


(2014/09/23 22:36), Steven Rostedt wrote:
> For future reference:
>
> On Mon, 22 Sep 2014 23:42:50 +0000
> Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:
>
>> ftracetest is a collection of testcase shell-scripts for ftrace.
>> To avoid regressions of ftrace, these testcases check correct
>> ftrace behaviors. If someone would like to add any features on
>> ftrace, the patch series should have at least one testcase for
>> checking the new behavior.
>>
>> Changes in v5:
>> - Fix a TODO item, since this already integrated to kselftest.
>> - Print the test name at the first line.
>>
>> Changes in v4:
>> - Move this under selftests. :)
>> - Add a copyright and note of GPLv2.
>> - Fix documents acconding to Steven's comments.
>> - Fix a small bug pointed by Namhyng.
>>
>> Changes in v3:
>> - Use "." instead of "source".
>> - Don't use -e option for echo since dash doesn't support it.
>>
>> Changes in v2:
>> - Remove unneeded 'function' keyword.
>> - Add abspath and find_testcases.
>> - Make OPT_TEST_CASES a local var.
>> - Ensure given testcase ended with .tc.
>> - Accept a directory option which has multiple testcases.
>> - Change [PASSED]/[FAILED] to [PASS]/[FAIL]
>> - Change the basic shell to sh (dash).
>
> Place the version changes after the '---'. They are great for patch
> series, but we prefer not to have them in the git logs. The "Link:" tag
> should allow people to find the version history of patches if they are
> interested. By placing the version updates after the '---', git will
> ignore them when pulling them in.

Ah, I see :)
For the next series, I'll do that.

>
>>
>> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
>> Acked-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
>> ---
>
> Also, please have the Signed-off-by be the last tag, otherwise it
> screws up my scripts ;-)

OK.

Thank you!

--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/