Re: [PATCH v6 1/2] regulator: st-pwm: get voltage and duty table from dts

[Chris Zhong]

On 09/24/2014 07:43 AM, Doug Anderson wrote:
> Chris,
>
> On Tue, Sep 23, 2014 at 8:53 AM, Chris Zhong <zyw@xxxxxxxxxxxxxx> wrote:
> > Get voltage & duty table from device tree might be better, other platforms can also use this
> > driver without any modify.
> >
> > Signed-off-by: Chris Zhong <zyw@xxxxxxxxxxxxxx>
> > Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> I finally managed to get everything setup and I've now tested this
> myself on an rk3288-based board.
>
> Tested-by: Doug Anderson <dianders@xxxxxxxxxxxx>
>
> I'd imagine the next step is for Lee to comment on the patch and when
> he's happy with it Mark Brown will land it?
>
>
> One thing that's still a bit odd (though no different than the
> behavior of the driver from before you touched it, so it shouldn't
> block landing IMHO) is that at boot time this regulator will report
> that it's at the highest voltage but the voltage won't actually change
> until the first client sets the voltage.
Yes, I knew this problem, since the default of duty cycle is 0, not a 
true value.
If we can get duty from pwm, this regulator will report a correct voltage.
> Also: if anyone reading is interested in this patch, it's possible
> you'll also be interested in my patch at
> <https://patchwork.kernel.org/patch/4960731/> to make sue that your
> voltage doesn't twiddle around at probe time.
>
>
> -Doug

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/