Re: [PATCH -next] greybus: es2: fix error return code in ap_probe()

From: Johan Hovold
Date: Wed Oct 19 2016 - 11:45:10 EST


On Wed, Oct 19, 2016 at 01:17:53PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> Fix to return a negative error code from the es2_arpc_in_enable() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for
> APBridgeA RPC")
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>

Thanks for the fix. This was clearly broken and would have led to
havoc on disconnect as well.

Reviewed-by: Johan Hovold <johan@xxxxxxxxxx>

Thanks,
Johan