Re: [PATCH v4 2/4] x86/phi: Add enabling of the R3MWAIT during boot

[Thomas Gleixner]

On Tue, 18 Oct 2016, Grzegorz Andrejczuk wrote:
> +static void probe_xeon_phi_r3mwait(struct cpuinfo_x86 *c)
> +{
> +	if (phi_r3mwait_disabled)
> +		return;

So you return when the command line option to disable the feature was
given. That's not really a good choice if the feature is already enabled
due to BIOS featuritis. This can also happen when you kexec from a enabled
kernel into one which has the command line option set.

You really should make sure that the command line option results in
disabling the feature no matter what.

Thanks,

	tglx