Re: [PATCH v2 1/1] usb: xhci: clean up error_bitmask usage

[Mathias Nyman]

On 21.10.2016 06:14, Lu Baolu wrote:
> In xhci_handle_event(), when errors are detected, driver always sets
> a bit in error_bitmask (one member of the xhci private driver data).
> That means users have to retrieve and decode the value of error_bitmask
> in xhci private driver data if they want to know whether those erros
> ever happened in xhci_handle_event(). Otherwise, those errors are just
> ignored silently.
>
> This patch cleans up this by replacing the setting of error_bitmask
> with the kernel print functions, so that users can easily check and
> report the errors happened in xhci_handle_event().
>
> Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> ---
> Changelog:
> V2:
>   - Remove "return" for failed port status event;
>   - Refine checking return value of handle_tx_event();
>   - Print the right TRB type value in debug message.

Thanks, added

-Mathias