Re: [PATCH] ASoC: soc-core: Fix probe deferral following prelink failure

From: Jon Hunter
Date: Mon Apr 01 2019 - 08:22:16 EST


Hi Mark,

On 04/03/2019 13:31, Jon Hunter wrote:
> From: Jonathan Hunter <jonathanh@xxxxxxxxxx>
>
> Commit 78a24e10cd94 ("ASoC: soc-core: clear platform pointers on error")
> re-worked the clean-up of any platform pointers that may have been
> initialised by the function snd_soc_init_platform(). This commit missed
> one error path where if any of the prelinks for a soundcard failed to
> initialise, then these platform pointers would not be cleaned-up. This
> then prevents the soundcard from being initialised following a probe
> deferral when any of the soundcard prelinks cannot be found.
>
> Fix this by ensuring that soc_cleanup_platform() is called when
> initialising the soundcard prelinks fails.
>
> Fixes: 78a24e10cd94 ("ASoC: soc-core: clear platform pointers on error")
>
> Signed-off-by: Jonathan Hunter <jonathanh@xxxxxxxxxx>

FYI, I am seeing that the deferral of soundcards failing with v5.1-rc3
because the above has not been merged yet. Just wanted to let you know
in case this one was not marked for v5.1.

Cheers
Jon

--
nvpublic