Re: [PATCH 3/4] ARM: dts: dra7: add PRU-ICSS modules

From: Tony Lindgren
Date: Mon Apr 01 2019 - 10:30:43 EST


* Roger Quadros <rogerq@xxxxxx> [190329 14:02]:
> Hi Tony,
>
> On 04/02/2019 20:03, Tony Lindgren wrote:
> > * Roger Quadros <rogerq@xxxxxx> [190204 15:54]:
> >> --- a/arch/arm/boot/dts/dra7.dtsi
> >> +++ b/arch/arm/boot/dts/dra7.dtsi
> >> @@ -167,6 +167,200 @@
> >> l4_per3: interconnect@48800000 {
> >> };
> >>
> >> + pru_icss1: target-module@4b200000 {
> >
> > I suggest you add these into dra7-pruss.dtsi as they
> > have internal interconnects. And eventually some of
> > the *pruss.dtsi files might become shared :) And we
> > avoid moving these around when we define the l3
> > interconnects and avoid a lot of extra long dtsi
> > line lengths with the added nestedness later on.
>
> PRUSS is only present on AM57x variants.
> I will move this to am57x-pruss.dtsi.
>
> This means all AM57x boards will have to include it.
>
> Is this OK?

Sure sounds good to me.

Regards,

Tony